Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResetPasswordBundle v2.0 #290

Open
9 of 20 tasks
jrushlow opened this issue Apr 4, 2024 · 1 comment
Open
9 of 20 tasks

ResetPasswordBundle v2.0 #290

jrushlow opened this issue Apr 4, 2024 · 1 comment
Labels
Feature New Feature

Comments

@jrushlow
Copy link
Collaborator

jrushlow commented Apr 4, 2024

Preface

2.x branch is NOT production ready

Version 2.0 is looking like it will be released in 2024. Version 1.x will be transitioned to security fixes only until it reaches its EOL in late 2024 / Q1 2025. New Features should be merged into 2.x unless absolutely necessary to preserve BC in 1.x

This issue will be updated to reflect any tasks required to get 2.0 out the door. Any issues concerning 2.0 should tag this thread / issue where appropriate.

Todo's for release

  • Determine base dependencies - Partially completed in bump minimum dependency versions #291 need to eval doctrine and annotations
  • Init UPGRADE.md to document path's forward to BC
  • Update CHANGELOG.md for 2.x
  • Totally Typed (properties, methods, returns, constructors)
  • #[SensitiveParameter] attributes for any secrets - prevent leaking sensitive data in logs with the SensitiveParameter attribute #315
  • Eval / widendoctrine/orm dependency in require-dev. Does ORM 3 || 4 affect bundle internals outside of tests
  • Eval / widen doctrine/persistence how does this affect bundle outside of tests
  • Check bundle DependencyInjection, Resources/config/verify_email_services.xml, & VerifyEmailBundle::class align with latest & greatest Symfony Bundle best practices - use new bundle structure #312
  • Translation file format's aligned with Symfony Translation best practices
  • Mark all classes @final, @internal where appropriate - make classes final #316
  • Eval implementation of PHPUnit 10/11, at the very least ensure test suite is compatible w/ 10/11 where possible.
  • Update .php-cs-fixer.dist.php as required
  • Update phpunit.xml.dist as required
  • Update MakerBundle, specifically, make:reset-password where applicable to prefer 2.x usage
  • Triage any existing issues / pulls - set milestone for 2.x or 1.x as required.
  • Remove phpstan baseline
  • Drop annotation support for entities [trait] remove annotation support for ResetPasswordRequest objects #303
  • Implement symfony/clock component

  • Review / test entire code base
  • Review / Sync README.md with bundle and make:reset-password
@laurentmuller
Copy link
Contributor

Hi,
I have the just question about PHP version. Why do You use the version 8.3 ?
The version 8.2 is not sufficient ?
Thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

No branches or pull requests

2 participants