test and cran commits

SymbolixAU · Jun 28, 2018 · bb28d83 · bb28d83
1 parent cef76fe
commit bb28d83
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,9 +1,11 @@
 ## Release Summary
 
 * Updates v1.0 to v1.1
-* Removed dependencies on undeclared packages from unit tests, as per CRAN request - email "CRAN packages maintained by you" from Kurt Hornik, 2018-05-18
+* Removed dependencies on undeclared packages from unit tests, as per CRAN request - email "CRAN packages maintained by you" from Kurt Hornik, 2018-05-18 (https://cran.r-project.org/web/checks/check_results_geojsonsf.html)
 * Build Note - Fedora clang & gcc  : installed size is 5.5mb / 6.8mb
   - The builds says the `libs` file is 3.7mb/5.0mb. I can't reduce this file size, all the compiled c++ headers and files are required. 
+* New gcc compiler warning : https://www.stats.ox.ac.uk/pub/bdr/gcc8/geojsonsf.out
+  - this warning references the souce C++ library `rapidjson`. There is an issue on their github page to fix this (https://github.com/Tencent/rapidjson/issues/1205). I will update this package once rapidjson has fixed this warning. 
 
 ## Test Environments
 

diff --git a/tests/testthat/test-sf_geojson.R b/tests/testthat/test-sf_geojson.R
@@ -153,12 +153,11 @@ test_that("errors are handled", {
 
 test_that("factors are strings", {
 
-	skip_on_cran()
-	skip_on_travis()
-
 	fgc <- '{"type":"Feature","geometry":{"type":"GeometryCollection","geometries":[{"type":"Point","coordinates":[100,0]},{"type":"LineString","coordinates":[[101,0],[102,1]]}]},"properties":{"prop0":"value0","prop1":"value1"}}'
 	sf <- geojson_sf(fgc)
 	sf$prop0 <- as.factor(sf$prop0)
+	geo <- sf_geojson(sf)
+	expect_true(grepl("value0", geo))
 })