New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate components for input and labels in forms #3202

Open

ciyer opened this issue Jun 11, 2024 · 0 comments

Labels

Contributor

ciyer commented Jun 11, 2024 •

edited

Loading

Description

In these following places, there is code that creates form fields with labels, help text, display of errors:

client/src/features/projectsV2/fields/DescriptionFormField.tsx
client/src/components/form-field/TextInput.tsx
(others to come)

We should go over this code and make sure that:

Accessibility guidelines are being respected https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA
Structure is consistent
If it makes sense, shared components are extracted and consistently re-used

ciyer added this to Renku UI board

ciyer converted this from a draft issue

ciyer moved this from Design/not-ready to Todo in Renku UI board

ciyer added the UI board label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment