Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/main view feed view UI #7

Merged
merged 8 commits into from
Feb 19, 2023
Merged

Feature/main view feed view UI #7

merged 8 commits into from
Feb 19, 2023

Conversation

drew105
Copy link
Member

@drew105 drew105 commented Feb 18, 2023

What is this PR? 👀

  1. MainView 에 들어가는 FeedView UI 를 토글버튼 스타일로 제작했습니다.


Changes 📃

  1. FeedView UI 제작
  2. iOS 타겟을 16.2 에서 16 으로 변경
  3. ColorExtension 오타 수정


Screenshot (optional) 📷

Screenshot 2023-02-19 at 12 17 58 AM
Screenshot 2023-02-19 at 12 22 11 AM


Additional & Warning points (optional) 📌

  1. 아직 삭제하기 버튼은 구현하지 못했습니다😭


Test result 🧪

  1. 버튼 토글에 따라 UI 가 잘 변경되는지 Preview 와 시뮬레이터를 통해 확인했습니다.
  2. iOS 타겟을 내렸을 때, 문제가 없는 것을 확인했습니다.
  3. ColorExtension 의 오타 수정을 확인했습니다.

@drew105 drew105 added bug Fix some Bug design Modify UI-related code docs Modify docs. ex) .readme feature Add new feature labels Feb 18, 2023
@drew105 drew105 requested a review from realhsb February 18, 2023 15:27
@drew105 drew105 linked an issue Feb 18, 2023 that may be closed by this pull request
✨ MainView UI #3
Open
3 tasks
@drew105 drew105 self-assigned this Feb 18, 2023
realhsb
realhsb reviewed Feb 19, 2023
View reviewed changes
TodayPhoto/TodayPhoto/Source/Views/MainView/FeedView.swift
.resizable()
.scaledToFill()
}
VStack {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VStack과 HStack... 보면 볼수록 신기한 칭구덜

realhsb
realhsb reviewed Feb 19, 2023
View reviewed changes
Copy link
Member

@realhsb realhsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많았습니다 😃

@drew105 drew105 requested a review from realhsb February 19, 2023 16:42
realhsb
realhsb approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@realhsb realhsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건가!

@realhsb realhsb merged commit 9274dd0 into develop Feb 19, 2023
@drew105 drew105 deleted the feature/MainViewUI branch February 23, 2023 03:07
@drew105 drew105 changed the title Feature/main view UI Feature/feed view UI Feb 23, 2023
@drew105 drew105 changed the title Feature/feed view UI Feature/main view feed view UI Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realhsb realhsb realhsb approved these changes

Assignees

@drew105 drew105

Labels
bug Fix some Bug design Modify UI-related code docs Modify docs. ex) .readme feature Add new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ MainView UI
2 participants
@drew105 @realhsb