Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback #9

Open
trieutran91 opened this issue Feb 3, 2020 · 0 comments
Open

Feedback #9

trieutran91 opened this issue Feb 3, 2020 · 0 comments

Comments

@trieutran91
Copy link
Contributor

trieutran91 commented Feb 3, 2020 •
edited by asbjornu
Loading

I have been testing the SDK and have following feedback and suggestion for improvements:

  1. The current code does not allow us to deliberately re-use code for Payments instruments. An example is PaymentsResource.cs where the methods for getting and creating payments are close to identical. This should be abstracted so there is only need for getpayment and createpayment.
  2. In src/SwedbankPay.Sdk/SwedbankPayHttpClient.cs:
    The SwedbankPayHttpClient class is made internal although GET, POST, and PATCH methods could be useful other places.
  3. The readme.md does not provide necessary information for a basic implementation. It would be helpful for the users to have a beginner's manual in order to get started with an implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trieutran91