Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvement #1169

Open
kranthivakati opened this issue Aug 4, 2024 · 6 comments
Open

UI improvement #1169

kranthivakati opened this issue Aug 4, 2024 · 6 comments

Comments

@kranthivakati
Copy link

kranthivakati commented Aug 4, 2024

bug1

Steps to reproduce

1.install the app from the playstore.
2.open the app & upload a photo which can be convert into pdf.
3.after uploading a photo click on FIlter images.
4.after clicking on Filter images we are navigating into that particular page in the left top Reset button doesn't displaying properly .

Expected behaviour

Reset button should be similar like save button

Actual behaviour

reset , save button which are in different type of buttons.

Would you like to work on the issue?

this is the low priority issue but this is major defect because user can see this bug and can say this app is not good.

@PaulBerger56
Copy link

I would like to work on this issue. I also sent an email to the address listed. I believe changing the width of the button should fix it and I can test it on several virtual devices on android studio to make sure screen size and shape does not affect the text.

@PaulBerger56
Copy link

I was able to fix the button's width to accomodate the text with the appropriate padding. I did have to reduce the width of the ImageCount box because the next image arrow was not visible on smaller devices after resizing the Reset button.

I will wait to hear back before putting in a pull request, but I have uploaded some screenshots of the virtual devices running on my end.

Pixel Fold Open

Pixel Fold Open

Pixel Fold Closed

Pixel Fold Closed

Small Android Phone

Small Phone

@kranthivakati
Copy link
Author

kranthivakati commented Aug 7, 2024 via email

@kranthivakati
Copy link
Author

@PaulBerger56 good job can you help me that where i can install latest build so that i can close this issue from my end

@PaulBerger56
Copy link

@kranthivakati Hey, I am a contributor, but do not own the project myself. I did a pull request with my fix, but it is up to the owner of the repository if they want to add it or not. If you are able to set this ticket back to open, I would do that and not close it until the repository owner updates the codebase.

@kranthivakati
Copy link
Author

kranthivakati commented Aug 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants