Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint warnings and improve code quality #1162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

foivospro
Copy link

Description

  1. Added content descriptions to images without contentDescription attributes to enhance accessibility.
  2. Set android:required="false" for unsupported Chrome OS hardware feature to ensure compatibility with all Chrome OS devices.
  3. Updated screenOrientation value to resolve compatibility issues.
  4. Removed redundant labels on activities.
  5. Added explicit nullness information (e.g., @nonnull or @nullable) to improve Kotlin referencing.
  6. Removed unused resources to optimize build performance.
  7. Updated backup configuration to use android:dataExtractionRules for Android 12 and higher.
  8. Applied borderless style to buttons for improved usability.
  9. Converted images to WebP format for better compression.
  10. Enabled text selection for dynamic text to improve usability.
  11. Fixed duplicate property key.

Fixes #1159

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

1. Added content descriptions to images without contentDescription attributes to enhance accessibility.
2. Set android:required="false" for unsupported Chrome OS hardware feature to ensure compatibility with all Chrome OS devices.
3. Updated screenOrientation value to resolve compatibility issues.
4. Removed redundant labels on activities.
5. Added explicit nullness information (e.g., @nonnull or @nullable) to improve Kotlin referencing.
6. Removed unused resources to optimize build performance.
7. Updated backup configuration to use android:dataExtractionRules for Android 12 and higher.
8. Applied borderless style to buttons for improved usability.
9. Converted images to WebP format for better compression.
10. Enabled text selection for dynamic text to improve usability.
11. Fixed duplicate property key.
Copy link

codeclimate bot commented Mar 30, 2024

Code Climate has analyzed commit 6c92ed6 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported Chrome OS Hardware Feature
1 participant