Skip to content

Commit

Permalink
Fix macos notarization
Browse files Browse the repository at this point in the history
  • Loading branch information
Syer10 committed Dec 2, 2023
1 parent 5d2632c commit 15ce1f7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/Build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ jobs:
arguments: >
${{ matrix.build }}
-Pcompose.desktop.mac.sign=true
-Pcompose.desktop.mac.signing.identity=${{ secrets.APPLE_IDENTITY_SHORT }}
-Pcompose.desktop.mac.signing.identity=${{ secrets.APPLE_IDENTITY }}
-Pcompose.desktop.mac.notarization.appleID=${{ secrets.APPLE_ID }}
-Pcompose.desktop.mac.notarization.password=${{ secrets.APPLE_PASSWORD }}
-Pidentity="${{ secrets.APPLE_IDENTITY }}"
-Pcompose.desktop.mac.notarization.teamID=${{ secrets.APPLE_TEAM_ID }}
- name: Sign APK
uses: r0adkll/sign-android-release@v1
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/Preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ jobs:
arguments: >
${{ matrix.build }}
-Pcompose.desktop.mac.sign=true
-Pcompose.desktop.mac.signing.identity=${{ secrets.APPLE_IDENTITY_SHORT }}
-Pcompose.desktop.mac.signing.identity=${{ secrets.APPLE_IDENTITY }}
-Pcompose.desktop.mac.notarization.appleID=${{ secrets.APPLE_ID }}
-Pcompose.desktop.mac.notarization.password=${{ secrets.APPLE_PASSWORD }}
-Pidentity="${{ secrets.APPLE_IDENTITY }}"
-Pcompose.desktop.mac.notarization.teamID=${{ secrets.APPLE_TEAM_ID }}
-Ppreview="${{ env.COMMIT_COUNT }}"
--stacktrace
Expand Down Expand Up @@ -195,7 +195,7 @@ jobs:
body: |
### Commits
https://github.com/Suwayomi/Tachidesk-JUI/compare/${{ env.PREV_RELEASE_SHA }}...${{ env.CURRENT_SHA }}
${{ env.COMMIT_LOGS }}
- name: Prune old releases
Expand Down
4 changes: 2 additions & 2 deletions buildSrc/src/main/kotlin/TachideskTasks.kt
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ private fun Task.onlyIfSigning(project: Project) {
}
}

private fun Project.getSigningIdentity() = "${properties["identity"]}".trim('"')
private fun Project.getSigningIdentity() = "${properties["compose.desktop.mac.signing.identity"].toString().trim('"')} (${properties["compose.desktop.mac.notarization.teamID"].toString().trim('"')})"

private fun isSigning(properties: Map<String, Any?>) = properties["compose.desktop.mac.sign"].toString() == "true"

Expand Down Expand Up @@ -242,4 +242,4 @@ fun TaskContainerScope.registerTachideskTasks(project: Project) {
named("processResources") {
dependsOn(runAllTachideskTasks)
}
}
}

0 comments on commit 15ce1f7

Please sign in to comment.