Fixed start date of shares created from a resignation of type transfer. #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving member were created with the start date = the end date of the shares of the gifting member. This would mean that on the resignation day, there are two shares active for each transferred share. The created shares should start a day after.
kerstenkenan
approved these changes
Dec 11, 2024
Theophile-Madet
deleted the
fix_resignation_transfer_shares_created_on_same_day
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a resignation of type transfer, the shares of the receiving member were created with the start date = the end date of the shares of the gifting member.
This would mean that on the resignation day, there are two shares active for each transferred share. The created shares should start a day after.