Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating tapir users through CreateGeneralTapirAccountView, invalid characters are not filtered #553

Open
Theophile-Madet opened this issue Sep 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Theophile-Madet
Copy link
Contributor

If we try to create a user with an invalid character in the username (we had the case with "krümelbande"), the tapir_user is created but an errors comes from LDAP where the user is then not created. There is then a data inconsistency between the Tapir db and the LDAP db.

  • The creation page should refuse invalid characters
  • If an error happens when creating the user on the LDAP side, the user on the Tapir side should be deleted from the DB (probably with @transation.atomic)
@Theophile-Madet Theophile-Madet added the bug Something isn't working label Sep 24, 2024
@Theophile-Madet Theophile-Madet moved this to Small improvements in Tapir Roadmap Sep 24, 2024
@Theophile-Madet
Copy link
Contributor Author

Looks like there's also an issue with family names being required by LDAP but not by the form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Small improvements
Development

No branches or pull requests

1 participant