From 6ca741b2a3558bd4268d915f6a6f4f27590171a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Th=C3=A9ophile=20Madet?= <theo.madet@posteo.net>
Date: Tue, 10 Dec 2024 18:59:49 +0100
Subject: [PATCH] Added options to the fancy graph: - add today's date or not -
 use first of month or last of month

---
 src/statistics/FancyGraphCard.tsx             |  25 +----
 src/statistics/components/DateRangePicker.tsx | 101 +++++++++++++++---
 src/statistics/utils.tsx                      |   4 +
 3 files changed, 94 insertions(+), 36 deletions(-)

diff --git a/src/statistics/FancyGraphCard.tsx b/src/statistics/FancyGraphCard.tsx
index a240225c..32cda775 100644
--- a/src/statistics/FancyGraphCard.tsx
+++ b/src/statistics/FancyGraphCard.tsx
@@ -68,27 +68,6 @@ const FancyGraphCard: React.FC = () => {
     setDateFrom(getFirstOfMonth(dateFromOnPageLoad));
   }, []);
 
-  useEffect(() => {
-    if (!dateFrom || !dateTo) return;
-
-    let currentDate = new Date(dateFrom);
-    const dates = [];
-    while (currentDate <= dateTo) {
-      dates.push(currentDate);
-      currentDate = new Date(currentDate);
-      currentDate.setDate(currentDate.getDate() + 32);
-      currentDate.setDate(1);
-    }
-    dates.push(currentDate);
-
-    const tomorrow = new Date();
-    tomorrow.setDate(tomorrow.getDate() + 1);
-    dates.push(tomorrow);
-
-    setDates(dates);
-    setGraphLabels(dates.map((date) => formatDate(date)));
-  }, [dateFrom, dateTo]);
-
   useEffect(() => {
     fillCachedData();
     buildAndSetGraphData();
@@ -253,12 +232,14 @@ const FancyGraphCard: React.FC = () => {
               <h5>
                 {gettext("Graph")} {fetching && <Spinner size={"sm"} />}
               </h5>
-              <span className={"d-flex gap-2"}>
+              <span className={"d-flex gap-2 align-items-center"}>
                 <DateRangePicker
                   dateFrom={dateFrom}
                   setDateFrom={setDateFrom}
                   dateTo={dateTo}
                   setDateTo={setDateTo}
+                  setDates={setDates}
+                  setGraphLabels={setGraphLabels}
                 />
                 <TapirButton
                   variant={"outline-secondary"}
diff --git a/src/statistics/components/DateRangePicker.tsx b/src/statistics/components/DateRangePicker.tsx
index e0d7b2d6..42144e9b 100644
--- a/src/statistics/components/DateRangePicker.tsx
+++ b/src/statistics/components/DateRangePicker.tsx
@@ -1,6 +1,7 @@
-import React from "react";
+import React, { useEffect, useState } from "react";
 import { FloatingLabel, Form } from "react-bootstrap";
-import { getFirstOfMonth } from "../utils.tsx";
+import { getFirstOfMonth, getLastOfMonth } from "../utils.tsx";
+import { formatDate } from "../../utils/formatDate.ts";
 
 declare let gettext: (english_text: string) => string;
 
@@ -9,6 +10,8 @@ interface DateRangePickerProps {
   setDateFrom: (date: Date) => void;
   dateTo: Date;
   setDateTo: (date: Date) => void;
+  setDates: (dates: Date[]) => void;
+  setGraphLabels: (graphLabels: string[]) => void;
 }
 
 const DateRangePicker: React.FC<DateRangePickerProps> = ({
@@ -16,20 +19,94 @@ const DateRangePicker: React.FC<DateRangePickerProps> = ({
   setDateFrom,
   dateTo,
   setDateTo,
+  setDates,
+  setGraphLabels,
 }) => {
+  const [includeToday, setIncludeToday] = useState(true);
+  const [startOfMonth, setStartOfMonth] = useState(true);
+
+  useEffect(() => {
+    if (!dateFrom || !dateTo) return;
+
+    let currentDate = new Date(dateFrom);
+    const dates = [];
+    while (currentDate <= dateTo) {
+      dates.push(currentDate);
+      currentDate = new Date(currentDate);
+      currentDate.setDate(currentDate.getDate() + (startOfMonth ? 32 : 1));
+      currentDate.setDate(1);
+      currentDate = adaptDate(currentDate);
+    }
+    dates.push(currentDate);
+
+    if (includeToday) {
+      const today = new Date();
+      let todayAlreadyInArray = false;
+      for (const date of dates) {
+        if (
+          date.getDate() === today.getDate() &&
+          date.getMonth() === today.getMonth() &&
+          date.getFullYear() === today.getFullYear()
+        ) {
+          todayAlreadyInArray = true;
+          break;
+        }
+      }
+      if (!todayAlreadyInArray) {
+        dates.push(today);
+      }
+    }
+
+    dates.sort((date1, date2) => date1.getTime() - date2.getTime());
+
+    setDates(dates);
+    setGraphLabels(dates.map((date) => formatDate(date)));
+  }, [dateFrom, dateTo, includeToday, startOfMonth]);
+
+  function adaptDate(date: Date) {
+    let dateAdapter = getFirstOfMonth;
+    if (!startOfMonth) {
+      dateAdapter = getLastOfMonth;
+    }
+    return dateAdapter(date);
+  }
+
+  function getDateInputValue(date: Date) {
+    if (isNaN(date.getTime())) {
+      return undefined;
+    }
+    return date.toISOString().substring(0, 10);
+  }
+
   return (
     <>
+      <Form.Group>
+        <Form.Check
+          type={"switch"}
+          checked={includeToday}
+          onChange={(e) => {
+            setIncludeToday(e.target.checked);
+          }}
+          label={"Include today"}
+        />
+      </Form.Group>
+      <Form.Group>
+        <Form.Select
+          onChange={(event) => {
+            setStartOfMonth(event.target.value === "startOfMonth");
+          }}
+        >
+          <option value={"startOfMonth"}>{gettext("First of month")}</option>
+          <option value={"lastOfMonth"}>{gettext("Last of month")}</option>
+        </Form.Select>
+      </Form.Group>
       <Form.Group>
         <FloatingLabel label={"Date from"}>
           <Form.Control
             type={"date"}
-            value={
-              !isNaN(dateFrom.getTime())
-                ? dateFrom.toISOString().substring(0, 10)
-                : undefined
-            }
+            value={getDateInputValue(dateFrom)}
             onChange={(event) => {
-              setDateFrom(getFirstOfMonth(new Date(event.target.value)));
+              setDateFrom(adaptDate(new Date(event.target.value)));
             }}
           />
         </FloatingLabel>
@@ -38,13 +115,9 @@ const DateRangePicker: React.FC<DateRangePickerProps> = ({
         <FloatingLabel label={"Date to"}>
           <Form.Control
             type={"date"}
-            value={
-              !isNaN(dateTo.getTime())
-                ? dateTo.toISOString().substring(0, 10)
-                : undefined
-            }
+            value={getDateInputValue(dateTo)}
             onChange={(event) => {
-              setDateTo(getFirstOfMonth(new Date(event.target.value)));
+              setDateTo(adaptDate(new Date(event.target.value)));
             }}
           />
         </FloatingLabel>
diff --git a/src/statistics/utils.tsx b/src/statistics/utils.tsx
index 2ed6af2b..02fcc07a 100644
--- a/src/statistics/utils.tsx
+++ b/src/statistics/utils.tsx
@@ -2,3 +2,7 @@ export function getFirstOfMonth(date: Date) {
   date.setDate(1);
   return date;
 }
+
+export function getLastOfMonth(date: Date) {
+  return new Date(date.getFullYear(), date.getMonth() + 1, 0);
+}