-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oauth 1.0 usage instructions are unclear #181
Comments
I understood from reading the code that I can just paste any made-up callback URL given that all that we're interested in are the query arguments. |
I stumbled upon https://www.mediawiki.org/wiki/Extension_talk:OAuthAuthentication#OAuth_%22callback%22_URL_for_OAuthAuthentication_applications just now. I haven't tried it yet though. Is that what would be recommended for WDI too? |
This is still valid, and may be more pressing that the rest of this ticket. |
The question mark that is part of the oauth callback URL is not byte-encoded. Keeping the byte-encoding mark in here leads to ``` response_qs = self.response_qs.split(b'?')[-1] TypeError: must be str or None, not bytes ``` This may differ per platform, but then maybe this PR will spark a discussion that has not yet been started from issue SuLab#181
Thank you for your pull request. I am restructuring the repo a bit to get a better grip on the library. Unfortunately, I am not an expert on OAUTH. Since raising the issue have you gained a better understanding? If so can I ask for another pull request? |
From the
README
's section on OAuth1:Two things are unclear at this point when trying to use this authentication mechanism within a script/bot:
OAuth "callback" URL
?Callback URL:
), which value should be insertedconsidering that a script does not have a webserver to call back to.
I also checked https://www.mediawiki.org/wiki/OAuth/For_Developers#OAuth_1.0a which didn't help all too much in finding answers to those questions.
The text was updated successfully, but these errors were encountered: