Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ErrorDescription::into_inner #492

Merged
merged 1 commit into from
Jul 14, 2024
Merged

feat: add ErrorDescription::into_inner #492

merged 1 commit into from
Jul 14, 2024

Conversation

matteopolak
Copy link
Contributor

resolves #488

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.87%. Comparing base (8adae12) to head (0e22146).

Files Patch % Lines
jsonschema/src/output.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   89.90%   89.87%   -0.03%     
==========================================
  Files          58       58              
  Lines        9942     9945       +3     
==========================================
  Hits         8938     8938              
- Misses       1004     1007       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jul 14, 2024

CodSpeed Performance Report

Merging #492 will improve performances by 98.13%

Comparing matteopolak:feature/expose_inner_error (0e22146) with master (8adae12)

Summary

⚡ 22 improvements
✅ 298 untouched benchmarks

Benchmarks breakdown

Benchmark master matteopolak:feature/expose_inner_error Change
additional_items_object 1234[jsonschema/is_valid/invalid] 760.6 ns 673.1 ns +13%
additional_properties_false [jsonschema/is_valid/valid] 456.9 ns 398.6 ns +14.63%
all_of 1[jsonschema/is_valid/invalid] 1,004.4 ns 887.8 ns +13.14%
any_of 1.5[jsonschema/is_valid/invalid] 1.2 µs 1.1 µs +10.79%
any_of 1[jsonschema/is_valid/valid] 727.8 ns 581.9 ns +25.06%
any_of_multiple_types foo[jsonschema/is_valid/valid] 941.1 ns 766.1 ns +22.84%
any_of_multiple_types null[jsonschema/is_valid/invalid] 941.9 ns 796.1 ns +18.32%
boolean_false 1[jsonschema/is_valid/invalid] 58.9 ns 29.7 ns +98.13%
const 1[jsonschema/is_valid/valid] 450.6 ns 392.2 ns +14.87%
const foo[jsonschema/is_valid/invalid] 327.8 ns 269.4 ns +21.65%
items 123[jsonschema/is_valid/valid] 743.9 ns 656.4 ns +13.33%
items 12x[jsonschema/is_valid/invalid] 742.2 ns 654.7 ns +13.36%
max_length foo[jsonschema/is_valid/valid] 665.6 ns 548.9 ns +21.26%
max_length foob[jsonschema/is_valid/invalid] 668.1 ns 551.4 ns +21.16%
max_properties a1[jsonschema/is_valid/valid] 329.2 ns 270.8 ns +21.54%
max_properties a1b1[jsonschema/is_valid/invalid] 300 ns 270.8 ns +10.77%
multiple_of_integer 212.4[jsonschema/is_valid/invalid] 482.5 ns 424.2 ns +13.75%
type_integer foo[jsonschema/is_valid/invalid] 298.6 ns 269.4 ns +10.82%
type_string 1[jsonschema/is_valid/invalid] 269.2 ns 240 ns +12.15%
type_string foo[jsonschema/is_valid/valid] 269.2 ns 240 ns +12.15%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Stranger6667 Stranger6667 merged commit 4017eba into Stranger6667:master Jul 14, 2024
32 of 33 checks passed
@matteopolak matteopolak deleted the feature/expose_inner_error branch July 14, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot obtain String from ErrorDescription
2 participants