-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Crashing when trying to display tooltip in different screen #145
Comments
Temporarily fixed and released: react-native-popover-view-fix-145 |
Thanks @rxliuli ❤️ 🙏 it's fixed crash but still there's blocking in another screen so you can't navigate or click at any element. for ex screen x & screen y then navigate before display tooltip in screen x to screen y |
I didn't encounter the problem you said, maybe you can modify it again |
@rxliuli 's fixed released as 1.5.6, please test and remove your NPM package if this works. @SherifMega Can you provide more details on what you mean by screen? Are you using a navigation library? Can you reproduce in an expo snack? |
@SteffeyDev if popover isn't within screen view the screen is blocked and you can not do any action if it's popover tried to appear. for example here in expo snack
https://snack.expo.dev/@shrief/popover-bug Record_2022-10-20-12-30-00.mp4 |
if you are trying to display popover from different screen (it leads app to crash)
so imagine this scenario
why because after some tracking in package itself
in
AdaptivePopover.js
in case 5
rect is
{"height": undefined, "width": undefined, "x": undefined, "y": undefined}
which leads to a lot of style errors in
BasePopover.js
Device/Setup Info:
react-native
version: [0.69.5]react-native-popover-view
version: [5.1.2]The text was updated successfully, but these errors were encountered: