Trace Actuator Updates #1356

TimHess · 2024-09-12T21:54:06Z

Description

While adding support for header filtering, I discovered we're a bit out of sync with Spring on this actuator in general, so I also decided to:

Remove everything related to the /trace (v1) actuator
Rename httptrace to httpexchanges (to align with Spring Boot 3), but still use /httptrace on TPCF

I also ran into an unhandled exception with the mappings actuator and included a fix for that

Fixes #1351

Quality checklist

Your code complies with our Coding Style.
You've updated unit and/or integration tests for your change, where applicable.
You've updated documentation for your change, where applicable.
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

TimHess · 2024-09-13T12:59:16Z

/azp run cleanup-code

azure-pipelines · 2024-09-13T12:59:27Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2024-09-13T13:03:39Z

Code cleanup failed to reformat and push changes.

View details here.

bart-vmware

First glance over the changes. It's pretty hard to see what's changed on GitHub due to renames. I'll run a file-by-file diff in the next round.

src/Management/src/Endpoint/Actuators/HttpExchanges/EndpointServiceCollectionExtensions.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/HttpExchange.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/HttpExchangesEndpointOptions.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/HttpExchangesDiagnosticObserver.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/HttpExchangesEndpointOptions.cs

src/Management/src/Endpoint/ConfigurationSchema.json

src/Management/src/Endpoint/EndpointOptionsExtensions.cs

src/Management/src/Endpoint/ManagementWebHostBuilderExtensions.cs

src/Management/test/Endpoint.Test/Actuators/HttpExchanges/EndpointMiddlewareTest.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/ConfigureHttpExchangesEndpointOptions.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/HttpExchangesDiagnosticObserver.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/HttpExchangesResult.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/ServiceCollectionExtensions.cs

src/Management/src/Endpoint/Actuators/RouteMappings/RouteMappingsEndpointHandler.cs

src/Management/test/Endpoint.Test/Actuators/CloudFoundry/EndpointMiddlewareTest.cs

src/Management/test/Endpoint.Test/ManagementWebApplicationBuilderExtensionsTest.cs

TimHess · 2024-09-18T23:19:05Z

/azp run cleanup-code

azure-pipelines · 2024-09-18T23:19:13Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2024-09-18T23:27:44Z

Code cleanup successfully reformatted files and pushed changes.

TimHess · 2024-09-19T15:30:05Z

/azp run cleanup-code

azure-pipelines · 2024-09-19T15:30:17Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2024-09-19T15:38:12Z

Code cleanup successfully reformatted files and pushed changes.

bart-vmware

I've completed a full sweep of all changes. Please don't rebase anymore until this PR is approved.

src/Management/src/Endpoint/Actuators/HttpExchanges/ServiceCollectionExtensions.cs

src/Management/src/Endpoint/ManagementHostBuilderExtensions.cs

src/Management/src/Endpoint/ManagementHostApplicationBuilderExtensions.cs

src/Management/src/Endpoint/ManagementWebHostBuilderExtensions.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/HttpExchangesDiagnosticObserver.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/ConfigureHttpExchangesEndpointOptions.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/HttpExchangesDiagnosticObserver.cs

Co-authored-by: Bart Koelman <[email protected]>

TimHess · 2024-09-23T21:53:51Z

/azp run Steeltoe.All

azure-pipelines · 2024-09-23T21:53:59Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2024-09-23T23:27:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2024-09-23T23:35:05Z

Code cleanup successfully reformatted files and pushed changes.

src/Management/test/Endpoint.Test/Actuators/HttpExchanges/EndpointMiddlewareTest.cs

...Management/test/Endpoint.Test/Actuators/HttpExchanges/HttpExchangesDiagnosticObserverTest.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/HttpExchange.cs

src/Management/test/Endpoint.Test/Actuators/HttpExchanges/EndpointMiddlewareTest.cs

src/Management/src/Endpoint/Actuators/HttpExchanges/HttpExchangesDiagnosticObserver.cs

…re/better assertions

azure-pipelines · 2024-09-24T21:13:58Z

Azure Pipelines successfully started running 1 pipeline(s).

src/Management/test/Endpoint.Test/Actuators/HttpExchanges/EndpointMiddlewareTest.cs

src/Management/test/Endpoint.Test/Actuators/Metrics/AspNetCoreHostingObserverTest.cs

azure-pipelines · 2024-09-25T13:35:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2024-09-25T13:37:49Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2024-09-25T13:39:04Z

Azure Pipelines successfully started running 1 pipeline(s).

sonarqubecloud · 2024-09-25T13:51:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

TimHess added Type/enhancement New feature or request Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Sep 12, 2024

TimHess added this to the 4.0.0-m1 milestone Sep 12, 2024

TimHess self-assigned this Sep 12, 2024

TimHess force-pushed the feature/header-masking-httptrace branch from a51e47c to ba2fd37 Compare September 13, 2024 13:57

bart-vmware reviewed Sep 13, 2024

View reviewed changes

TimHess force-pushed the feature/header-masking-httptrace branch 3 times, most recently from 3609088 to 27ff773 Compare September 16, 2024 20:15

bart-vmware requested changes Sep 17, 2024

View reviewed changes

bart-vmware mentioned this pull request Sep 17, 2024

Configuration schema generator: fix missing cref inside para tag #1358

Merged

5 tasks

TimHess force-pushed the feature/header-masking-httptrace branch 2 times, most recently from c25ef15 to 8d78612 Compare September 18, 2024 22:16

TimHess changed the base branch from main to fix-schema-cref-in-para September 18, 2024 22:16

TimHess requested a review from bart-vmware September 18, 2024 23:36

TimHess marked this pull request as ready for review September 19, 2024 13:48

bart-vmware closed this in #1358 Sep 19, 2024

TimHess reopened this Sep 19, 2024

TimHess changed the base branch from fix-schema-cref-in-para to main September 19, 2024 14:06

TimHess force-pushed the feature/header-masking-httptrace branch from df33a65 to 38337b9 Compare September 19, 2024 15:47

TimHess mentioned this pull request Sep 20, 2024

Revisit Actuator MediaTypeVersion handling #1367

Open

TimHess added 2 commits September 20, 2024 15:49

Replace /trace and /httptrace with SpringBoot3-compatible /httpexchanges

154493c

drop HttpClientDesktopObserver

42752ce

TimHess force-pushed the feature/header-masking-httptrace branch from 5955f36 to 42752ce Compare September 20, 2024 20:56

TimHess requested a review from bart-vmware September 20, 2024 20:57

bart-vmware requested changes Sep 23, 2024

View reviewed changes

TimHess and others added 5 commits September 23, 2024 09:37

Apply suggestions from code review

bcf8c27

Co-authored-by: Bart Koelman <[email protected]>

Apply suggestions from code review

025df11

Co-authored-by: Bart Koelman <[email protected]>

Apply suggestions from code review

7e31de4

Co-authored-by: Bart Koelman <[email protected]>

PR feedback

97af1c5

Use DateTime.*Utc*Now.Date

ec98cea

Automated code cleanup from Steeltoe cibuild

0f72484

Add HTTP exchange test that asserts on JSON structure

aaf76b6

bart-vmware requested changes Sep 24, 2024

View reviewed changes

update api spec, remove reflection from AspNetCoreHostingObserver, mo…

b036ab2

…re/better assertions

TimHess requested a review from bart-vmware September 24, 2024 21:23

bart-vmware requested changes Sep 25, 2024

View reviewed changes

src/Management/test/Endpoint.Test/Actuators/HttpExchanges/EndpointMiddlewareTest.cs Outdated Show resolved Hide resolved

src/Management/test/Endpoint.Test/Actuators/Metrics/AspNetCoreHostingObserverTest.cs Outdated Show resolved Hide resolved

address feedback

4f048e7

bart-vmware approved these changes Sep 25, 2024

View reviewed changes

TimHess merged commit bb9c92b into main Sep 25, 2024
22 checks passed

TimHess deleted the feature/header-masking-httptrace branch September 25, 2024 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trace Actuator Updates #1356

Trace Actuator Updates #1356

TimHess commented Sep 12, 2024 •

edited

Loading

TimHess commented Sep 13, 2024

azure-pipelines bot commented Sep 13, 2024

azure-pipelines bot commented Sep 13, 2024

bart-vmware left a comment

TimHess commented Sep 18, 2024

azure-pipelines bot commented Sep 18, 2024

azure-pipelines bot commented Sep 18, 2024

TimHess commented Sep 19, 2024 •

edited

Loading

azure-pipelines bot commented Sep 19, 2024

azure-pipelines bot commented Sep 19, 2024

bart-vmware left a comment

TimHess commented Sep 23, 2024 •

edited by bart-vmware

Loading

azure-pipelines bot commented Sep 23, 2024

azure-pipelines bot commented Sep 23, 2024

azure-pipelines bot commented Sep 23, 2024

azure-pipelines bot commented Sep 24, 2024

azure-pipelines bot commented Sep 25, 2024

azure-pipelines bot commented Sep 25, 2024

azure-pipelines bot commented Sep 25, 2024

sonarqubecloud bot commented Sep 25, 2024

Trace Actuator Updates #1356

Trace Actuator Updates #1356

Conversation

TimHess commented Sep 12, 2024 • edited Loading

Description

Quality checklist

TimHess commented Sep 13, 2024

azure-pipelines bot commented Sep 13, 2024

azure-pipelines bot commented Sep 13, 2024

bart-vmware left a comment

Choose a reason for hiding this comment

TimHess commented Sep 18, 2024

azure-pipelines bot commented Sep 18, 2024

azure-pipelines bot commented Sep 18, 2024

TimHess commented Sep 19, 2024 • edited Loading

azure-pipelines bot commented Sep 19, 2024

azure-pipelines bot commented Sep 19, 2024

bart-vmware left a comment

Choose a reason for hiding this comment

TimHess commented Sep 23, 2024 • edited by bart-vmware Loading

azure-pipelines bot commented Sep 23, 2024

azure-pipelines bot commented Sep 23, 2024

azure-pipelines bot commented Sep 23, 2024

azure-pipelines bot commented Sep 24, 2024

azure-pipelines bot commented Sep 25, 2024

azure-pipelines bot commented Sep 25, 2024

azure-pipelines bot commented Sep 25, 2024

sonarqubecloud bot commented Sep 25, 2024

Quality Gate passed

TimHess commented Sep 12, 2024 •

edited

Loading

TimHess commented Sep 19, 2024 •

edited

Loading

TimHess commented Sep 23, 2024 •

edited by bart-vmware

Loading