Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect status code when actuator is disabled #1410

Open
bart-vmware opened this issue Nov 21, 2024 · 0 comments · May be fixed by #1408
Open

Incorrect status code when actuator is disabled #1410

bart-vmware opened this issue Nov 21, 2024 · 0 comments · May be fixed by #1408
Labels
Component/Management Issues related to Steeltoe Management (actuators) Status/needs-investigation Tickets needs more investigation

Comments

@bart-vmware
Copy link
Member

bart-vmware commented Nov 21, 2024 •
edited
Loading

Interestingly, with default exposure settings, where /refresh is not exposed, requests to that actuator return 405 instead of 404. I don't know if it matters that we perform the verb check before an exposure check, but I wasn't expecting that.

See #1408. Though I'm not sure if doing so is a good idea, there are tradeoffs.

Originally posted by @bart-vmware in SteeltoeOSS/Documentation#330 (comment)
@bart-vmware bart-vmware mentioned this issue Nov 21, 2024
Merged
@bart-vmware bart-vmware added Component/Management Issues related to Steeltoe Management (actuators) Status/needs-investigation Tickets needs more investigation labels Nov 21, 2024
@bart-vmware bart-vmware linked a pull request Nov 21, 2024 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component/Management Issues related to Steeltoe Management (actuators) Status/needs-investigation Tickets needs more investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check exposure/enabled for HTTP verb match in management endpoints SteeltoeOSS/Steeltoe
1 participant
@bart-vmware