Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): include fonts as assets #6009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JessicaBarh
Copy link
Contributor

Closes StatCan#58

Fonts for the centraldashboard component are loaded from https://fonts.googleapis.com/. We have experienced some issues with page load being blocked, waiting on fonts.gstatic.com.

We decided to move all the fonts into the service so issues with external services don't affect ours.

@aws-kf-ci-bot
Copy link

Hi @JessicaBarh. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kimwnasptd after the PR has been reviewed.
You can assign the PR to them by writing /assign @kimwnasptd in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@aws-kf-ci-bot
Copy link

@JessicaBarh: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-kubeflow-presubmit ddfd70d link /test kubeflow-kubeflow-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had activity in 90 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a GitHub Project
  2. they are added to a GitHub Milestone
  3. they have a priority label: priority/p0, priority/p1, priority/p2, priority/p3
  4. they have the frozen label: lifecycle/frozen

@juliusvonkohout
Copy link
Member

Can you join the next notebooks WG meeting in two weeks ? We are always looking for help.

https://www.kubeflow.org/docs/about/community/#kubeflow-community-calendars has the calendar and meeting notes.

You can also reach us on slack in the channel wg-notebooks and wg-manifests.

@stale stale bot removed the lifecycle/stale label Aug 31, 2023
@Souheil-Yazji Souheil-Yazji deleted the centraldashboard-fonts-as-assets branch March 21, 2024 15:42
@Souheil-Yazji Souheil-Yazji restored the centraldashboard-fonts-as-assets branch March 21, 2024 15:42
@thesuperzapper
Copy link
Member

We need to confirm the license on these fonts, but including them sounds sensible, if they are able to be licensed under Apache 2.0.

@thesuperzapper thesuperzapper added this to the v1.9.1 milestone May 13, 2024
@thesuperzapper thesuperzapper changed the title feat(centraldashboard): add fonts as assets feat(dashboard): add include fonts as assets May 13, 2024
@thesuperzapper thesuperzapper changed the title feat(dashboard): add include fonts as assets feat(dashboard): include fonts as assets May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement moving fonts as a service Upstream
6 participants