-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): include fonts as assets #6009
base: master
Are you sure you want to change the base?
feat(dashboard): include fonts as assets #6009
Conversation
Hi @JessicaBarh. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@JessicaBarh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This issue has been automatically marked as stale because it has not had activity in 90 days. Thank you for your contributions. Issues never become stale if any of the following is true:
|
Can you join the next notebooks WG meeting in two weeks ? We are always looking for help. https://www.kubeflow.org/docs/about/community/#kubeflow-community-calendars has the calendar and meeting notes. You can also reach us on slack in the channel wg-notebooks and wg-manifests. |
We need to confirm the license on these fonts, but including them sounds sensible, if they are able to be licensed under Apache 2.0. |
Closes StatCan#58
Fonts for the centraldashboard component are loaded from https://fonts.googleapis.com/. We have experienced some issues with page load being blocked, waiting on fonts.gstatic.com.
We decided to move all the fonts into the service so issues with external services don't affect ours.