Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3 Upgrade: Jupyter/CWA #831

Closed
1 of 10 tasks
wg102 opened this issue Jan 18, 2022 · 6 comments
Closed
1 of 10 tasks

1.3 Upgrade: Jupyter/CWA #831

wg102 opened this issue Jan 18, 2022 · 6 comments
Labels
component/jupyter Kubeflow notebooks and associated container images component/kubeflow Kubeflow Related size/XL 6+ days

Comments

@wg102
Copy link
Contributor

wg102 commented Jan 18, 2022 •
edited
Loading

This is an item of #530

Areas of concern:

  • go code needs to be recoded or at least upgraded

  • dependant on kubeflow-controller -> possibly copy the necessary folder into the new place/repo to avoid the dependency.

  • folder structure completely different

  • want to merge into the kubeflow/crud-web-apps? (to confirm)

  • how? have a go backend folder? (the upstreaming of this is part of a current issue Upstream the client code for Kubeflow CRDs aaw-kubeflow-controller#20)

  • What about the Volume page/feature?
    We have similar ish designs but not in the same locations.

  • What about the tensorboard one?

  • they have a 'common' folder...

  • i18n is done in a different way (i18n is a 1.4 feature)
    -> affects deployment (when reaching 1.4)

  • Is the deployment different than it use to be?

  • Kubecost?

  • Features/fix we did to jupyter-apis that is ours

    • Kubecost
    • image help text
    • Advance settings
    • KF_LANG
      • stuff not merged in 1.3 such as

  • MISSING FEATURES: Last time i tested 1.3 there were quite a bit of validation that was missing.

Steps for solution

The numbers are the steps, anything taht is not a clear number are possibilities.

  1. This would be done after the 1.3 upgrade of central-dashboard (aka the kubeflow repo)
  2. GO backend: there are probably quite a few changes in the backend, I think it might be quicker to recode it than to update our current go code.
    2.1.1 We would create a go backend, import the dependency on the kubeflow-controller rpo
    Recode the integrality of the go backend compared to the current code for 1.3.1.
    2.1.2 Only code the feature we need.
    2.2 Other idea is to keep the backend in jupyter-api and have a dependency on it, but in either case we need to recode the thing.
  3. front end needs to import all our changes from the jupyter-api repo
  4. Kubecost might need to be upgraded or moved.

Child tickets:

Separrate the work in smaller items
@wg102 wg102 added component/kubeflow Kubeflow Related size/XL 6+ days component/jupyter Kubeflow notebooks and associated container images labels Jan 18, 2022
@wg102 wg102 changed the title Jupyter/CWA 1.3 Upgrade: Jupyter/CWA Jan 18, 2022
@wg102 wg102 mentioned this issue Jan 18, 2022
Closed
@wg102
Copy link
Contributor Author

wg102 commented Jan 19, 2022

We need to test if the performance issue was fixed. if it is we might not even need to recode into go.

@wg102
Copy link
Contributor Author

wg102 commented Jan 26, 2022 •
edited by Jose-Matsuda
Loading

This issue will be half like an epic. So the actual epic is not swamped.

  1. Do we want to code the things we don't use as well?
  2. Do we want to upstream the go code? --> we can have a separate folder just named go-backend that contains the go specific portion if we want

The parts to code:

  • Common
  • Jupyter
  • Tensoboards
  • Volumes

This is a copy paste of my comment here

The most important folder to tackle first is probably going to be the crud-web-app/common/backend/kubeflow/kubeflow/crud_backend/api as these get used by the files in jupyter/backend/apps.

These api files also resemble (at least in name) the current go files created by Zach in jupyter-apis so that may help in accelerating and easing us more into what / how things are done.

These files can be assigned with a file per person initially where say an 'equivalent' or Zach's work exists jupyter-apis first.

It may also be good to just have a folder named go-backend in places necessary so that we don't completely nuke the existing code, and may make it easier to upstream .

This was referenced Jan 26, 2022
Closed
Closed
This was referenced Feb 8, 2022
Open
Open
Open
Open
Open
Open
@skyeturriff
Copy link

skyeturriff commented Feb 16, 2022 •
edited by Jose-Matsuda
Loading

Find the commits relating to the following customizations, and list them under the related feature

Front end customizations:

Back end customizations:

  • support for start/stop notebooks
  • if we want, adjust our backend to support their new volumes page
  • check for any new endpoints in 1.3 api that are not currently implemented in ours
    • jupyter (Skye)
    • common (Jose)
    • volumes

@saffaalvi
Copy link

saffaalvi commented Feb 16, 2022 •
edited
Loading

Frontend changes (commits)

2020

Aug 11

Aug 19/20

Aug 21

Sep 1

Sep 16

Sep 24

Oct 6

Oct 7

Oct 14

Oct 21

Nov 3

Nov 4

Nov 6

Nov 10

Dec 16

2021

Jan 7

Jan 21

Jan 26

Feb. 16

Apr. 20

May 21

@wg102 wg102 mentioned this issue Feb 17, 2022
Closed
23 tasks
@wg102
Copy link
Contributor Author

wg102 commented Feb 17, 2022

REmoving this from the stprint and until working with 1.4... see the issue mentionned above for details.

@chuckbelisle
Copy link
Contributor

Closing and archiving issue, KF is now at 1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/jupyter Kubeflow notebooks and associated container images component/kubeflow Kubeflow Related size/XL 6+ days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chuckbelisle @skyeturriff @wg102 @saffaalvi