Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar does not cover footer #89

Open
ChrTall opened this issue Aug 20, 2020 · 1 comment
Open

Sidebar does not cover footer #89

ChrTall opened this issue Aug 20, 2020 · 1 comment

Comments

@ChrTall
Copy link

ChrTall commented Aug 20, 2020

I use your Simple Sidebar which was easily configured and is pretty nice. Thanks a lot by the way.
The only thing that I cannot get to work is placing the footer so that it gets covered by the sidebar.
The same way to sidebar is covering the navbar and content for example.
I placed the footer inside the #page-content-wrapper div.
Maybe it is just a configuration issue. Any help would be appreciated.

@satpal123
Copy link

@ChrTall I had the same issue too. The way I fixed was to place the Footer outside the <div class="d-flex" id="wrapper"> and add bg-light to the footer class as mentioned below.

<div class="d-flex" id="wrapper">
<div id="page-content-wrapper">
    <header>
     .....
     </header>
     <div class="container-fluid">
           <main role="main" class="pb-3">
            @RenderBody()
           /main>
      </div>
</div>
</div>
<footer class="border-top footer text-muted bg-light">
     <div class="container-fluid">
      .......
     </div>
</footer>

Also comment out the margin-botton in the site.css (wwwroot > css > site.css)

body {
  /* Margin bottom by footer height */
  /*margin-bottom: 60px;*/
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants