Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split codes up in multiple files? #12

Open
per-samuelsson opened this issue Mar 15, 2017 · 2 comments
Open

Split codes up in multiple files? #12

per-samuelsson opened this issue Mar 15, 2017 · 2 comments

Comments

@per-samuelsson
Copy link
Contributor

Like one per category:

General.ErrorCodes.xml
Database.ErrorCodes.xml
Development.ErrorCodes.xml

Would it be hard do you think, @chrhol? Would make it easier to edit for sure, and also to get an overview over categories. Plus less merging. Maybe not a high prio though.

@chrhol
Copy link

chrhol commented Mar 15, 2017

Sounds reasonable, and not to hard to implement I think. When reading the xmlfile today, the category (facility in code) and the errorcodes are separate objects. And the code for reading xml is a bit more readable than other code, so to support multiple input-files would not be a major change.

@k-rus
Copy link

k-rus commented Mar 17, 2017

This will give minor improvement. To make the life of developers better requires more radical improvements. Currently it takes for me considerable time to add new error code, since first I need to find if I can use an existing code, and then if not I need to decide where to add. Current categorisation of the error codes is nontrivial for me.

So my suggestion is not spend time on this if it is not straight forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants