Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc]Update Sql_faq.md #54780

Closed
wants to merge 1 commit into from
Closed

[Doc]Update Sql_faq.md #54780

wants to merge 1 commit into from

Conversation

Johnsonginati
Copy link
Contributor

@Johnsonginati Johnsonginati commented Jan 7, 2025

Fix the description about alter table

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • [x ] Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Fix the description about alter table

Signed-off-by: Johnson Ginati <[email protected]>
@github-actions github-actions bot added title needs [type] documentation Improvements or additions to documentation labels Jan 7, 2025
@Johnsonginati Johnsonginati changed the title Update Sql_faq.md [Docs]Update Sql_faq.md Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 7, 2025

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 7, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@DanRoscigno DanRoscigno changed the title [Docs]Update Sql_faq.md [Doc]Update Sql_faq.md Jan 7, 2025
@EsoragotoSpirit
Copy link
Contributor

Hi @Johnsonginati, thank you for your interest in our documentation. I have discussed this with our engineering team and they believe the original text is correct. Loading data during Schema Change will indeed affect the performance of the Schema Change, so we decided to close this PR. But you are always welcome to contribute to StarRocks documentation if you identify any issues! Have a good day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants