Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix chunk accumulator miss assign _max_size (backport #52579) #52596

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2024

Why I'm doing:

(java.sql.SQLException)(conn=143)Intermediate chunk size mustnot be greater than 1024,actually 4095 after 0-th operator spillable_org .mariadb.jdbc.export.ExceptionFactory.createException():299
org.mariadb.jdbc.export.ExceptionFactory.create():370
org .mariadb.jdbc.message.ClientMessage.readPacket():137org.mariadb.jdbc.client.impl.StandardClient.readPacket():840org .mariadb.jdbc.client.impl.StandardClient.readResults():779org.mariadb.jdbc.client.impl.StandardClient.readResponse():698org. mariadb.jdbc.client.impl.StandardClient.execute():641
org .mariadb.jdbc.client.impl.MultiPrimaryClient.execute():347
org.mariadb.jdbc.Statement.executelnternal():935
org.mariadb.jdbc.Statement.executeUpdate():917

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52579 done by [Mergify](https://mergify.com). ## Why I'm doing:
(java.sql.SQLException)(conn=143)Intermediate chunk size mustnot be greater than 1024,actually 4095 after 0-th operator spillable_org .mariadb.jdbc.export.ExceptionFactory.createException():299
org.mariadb.jdbc.export.ExceptionFactory.create():370
org .mariadb.jdbc.message.ClientMessage.readPacket():137org.mariadb.jdbc.client.impl.StandardClient.readPacket():840org .mariadb.jdbc.client.impl.StandardClient.readResults():779org.mariadb.jdbc.client.impl.StandardClient.readResponse():698org. mariadb.jdbc.client.impl.StandardClient.execute():641
org .mariadb.jdbc.client.impl.MultiPrimaryClient.execute():347
org.mariadb.jdbc.Statement.executelnternal():935
org.mariadb.jdbc.Statement.executeUpdate():917

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

```
(java.sql.SQLException)(conn=143)Intermediate chunk size mustnot be greater than 1024,actually 4095 after 0-th operator spillable_org .mariadb.jdbc.export.ExceptionFactory.createException():299
org.mariadb.jdbc.export.ExceptionFactory.create():370
org .mariadb.jdbc.message.ClientMessage.readPacket():137org.mariadb.jdbc.client.impl.StandardClient.readPacket():840org .mariadb.jdbc.client.impl.StandardClient.readResults():779org.mariadb.jdbc.client.impl.StandardClient.readResponse():698org. mariadb.jdbc.client.impl.StandardClient.execute():641
org .mariadb.jdbc.client.impl.MultiPrimaryClient.execute():347
org.mariadb.jdbc.Statement.executelnternal():935
org.mariadb.jdbc.Statement.executeUpdate():917
```

Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 19c386f)

# Conflicts:
#	test/sql/test_spill/R/test_spill_aggregate
#	test/sql/test_spill/T/test_spill_aggregate
@mergify mergify bot added the conflicts label Nov 4, 2024
Copy link
Contributor Author

mergify bot commented Nov 4, 2024

Cherry-pick of 19c386f has failed:

On branch mergify/bp/branch-3.1/pr-52579
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 19c386f709.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/exec/pipeline/aggregate/spillable_aggregate_blocking_source_operator.cpp
	modified:   be/src/exec/pipeline/aggregate/spillable_aggregate_distinct_blocking_operator.cpp
	modified:   be/src/exec/pipeline/hash_partition_context.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/sql/test_spill/R/test_spill_aggregate
	both modified:   test/sql/test_spill/T/test_spill_aggregate

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Nov 4, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@stdpain stdpain reopened this Dec 4, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) December 4, 2024 06:34
@wanpengfei-git wanpengfei-git merged commit c54b6ee into branch-3.1 Dec 4, 2024
26 of 27 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.1/pr-52579 branch December 4, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants