Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a warning when using the wrong version of the mod #44

Open
LelouBil opened this issue Nov 24, 2020 · 3 comments
Open

Include a warning when using the wrong version of the mod #44

LelouBil opened this issue Nov 24, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request installer Things concering the installer wontfix This will not be worked on
Milestone

Comments

@LelouBil
Copy link
Collaborator

Use Application_get_version to get the current version of the game and compare the the dll supported one.

Maybe also do a api call to github to check the latest supported version and prompt the user to update.

@LelouBil LelouBil added the enhancement New feature or request label Nov 24, 2020
@LelouBil LelouBil self-assigned this Nov 24, 2020
@StarGate01 StarGate01 added this to the 1.0.0.9 milestone Nov 24, 2020
@StarGate01
Copy link
Owner

We should also check the hash of the Among Us binaries (exe and GameAssembly.dll), because as we have seen sometimes the version number is not incremented.

@StarGate01
Copy link
Owner

Version number gets printed starting with version 1.0.0.10, but no additional checks are performed.

@StarGate01 StarGate01 added the installer Things concering the installer label Dec 22, 2020
@StarGate01
Copy link
Owner

Check from inside the mod is not really possible, so this would be a job for the installer. We would have to find a way to read the game version without actually launching the game.

@StarGate01 StarGate01 added the wontfix This will not be worked on label Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request installer Things concering the installer wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants