Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement contact entity #82

Open
pchalupa opened this issue Jan 7, 2021 · 5 comments
Open

Implement contact entity #82

pchalupa opened this issue Jan 7, 2021 · 5 comments
Labels
feature New feature or request

Comments

@pchalupa
Copy link
Contributor

pchalupa commented Jan 7, 2021

Describe the solution you'd like
I would like to be able to create contact (person) with personal information. Also be able to edit and delete.

@pchalupa pchalupa added the feature New feature or request label Jan 7, 2021
@pchalupa
Copy link
Contributor Author

There could be two ways how to handle this issue. We can add users as User, like we have already and just handle if user account has privileges to log in into admin. User entity already contains the name, surname, avatar and e-mail field. So the whole works will be just adding some type of description and state (privileges).
The other way is just implement whole new model for contact. We can define all possible data fields, but i don't like the fact, that we basically doubling abstract user entity.

@oliverstasa
Copy link
Member

Those I got to implement has to have:

  • profile pic
  • description
  • add/edit/delete
  • change order
  • activace/deactivate
    They all seem addable to current User, I agree. In Admin, there should be some optional choice to create login/password or to leave those blank, otherwise it'd be bothersome.

@pchalupa
Copy link
Contributor Author

And on the front end you will call /api/user which response with all users data. And we can make /api/user/id to return just single user.

@oliverstasa
Copy link
Member

Actually, now that I think about it... I fell like this should be separate template, not the "user" one... idk, but, there would be so much disposible information... it should be clean, no unnecessary data - it doesn't even has to have the name User, it's not like that, they are not users - it's just a page where is title, description and image, it could be anything, it could be "partners" - logos with text, it could be rooms in a hotel... how about using "gallery"? I fell it's the same concept...

@pchalupa
Copy link
Contributor Author

Well, we should left this issue open for future attempts of implementing this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants