Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coming features] Refactor of project structure #225

Closed
martinezmatias opened this issue May 26, 2020 · 1 comment
Closed

[coming features] Refactor of project structure #225

martinezmatias opened this issue May 26, 2020 · 1 comment

Comments

@martinezmatias
Copy link
Collaborator

Currently, we project has the code related to features extraction splitted in two packages:
fr.inria.coming.codefeatures and fr.inria.prophet4j.
All code related to features inside 'fr.inria.prophet4j.should be moved tofr.inria.coming.codefeatures. Moreover, we should do a cleaning of the fr.inria.prophet4j. ` package.
For example, there are some classes that have duplicate features (and old set of S4R features)
S4RFeature, S4ROFeature.

Then, we need to decide where to put all the code from fr.inria.prophet4j.that we dont move to fr.inria.coming.codefeatures (for example learner, demo)

@monperrus
Copy link
Contributor

cleaned feature code in #266 and #267

now we only have EnhancedFeatures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants