You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that in this project requests library is used to make queries.
However there is no handling of potential exceptions in external library.
I want you to add some external exceptions wrapping into SparkPostException at least (since I've no access to push into the repo).
The change is pretty simple and would make your code much better, because it's insane when external lib raises errors from another external lib that is used in this one.
My suggestion is something like this (compatible with both Python2.x and Python 3.x):
Hi there!
I've noticed that in this project
requests
library is used to make queries.However there is no handling of potential exceptions in external library.
I want you to add some external exceptions wrapping into
SparkPostException
at least (since I've no access to push into the repo).The change is pretty simple and would make your code much better, because it's insane when external lib raises errors from another external lib that is used in this one.
My suggestion is something like this (compatible with both Python2.x and Python 3.x):
In case of dropping Python 2.x support
from exc
part could be added for providing more details about external lib exception.Thanks a lot and have a nice day!
The text was updated successfully, but these errors were encountered: