Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using SLF4J #86

Open
mbaumbach opened this issue Apr 20, 2018 · 2 comments
Open

Switch to using SLF4J #86

mbaumbach opened this issue Apr 20, 2018 · 2 comments

Comments

@mbaumbach
Copy link

Instead of directly depending on log4j, using the SLF4J logging facade will allow dependent applications of the Sparkpost library to pick/configure a logging library of their choice or at least not conflict with different versions of log4j.

The use case for me was that I'm using the logback logging library in my application, but the sparkpost library required me to configure both log4j and logback to have the same kind of logging formats, levels, and appenders.

I'll be submitting a PR in a few that contains the changes necessary for this.
@mbaumbach mbaumbach mentioned this issue Apr 20, 2018
Open
@mbaumbach
Copy link
Author

mbaumbach commented Apr 20, 2018 •
edited
Loading

The PR is #87. I created this separate issue in case this still wants to be addressed, but the PR wants to be abandoned. 😄

@pedro-carneiro
Copy link

It would be nice to have this. Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbaumbach @pedro-carneiro