-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Z:R] Implement Hitgroup Knockback config, Zombie Class specific knockback config. #232
Conversation
hello? why still using KeyValues |
sorry. It's my bad that I only know how to use KeyValues. I don't know how to use .jsonc. It would be great if someone has more experiences to help my bad code. |
Should be fine, it's unlikely we'll ever migrate all our old cfgs away from KeyValues anyways, and this file is simple enough that JSON arrays should never be needed. That was really the only reason we justified the playerclass migration. |
06206b9
to
1d14e44
Compare
I test this in my server and work so nice +1 to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine lfm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and sorry for the delay, none of the "dev servers" wanted to use this feature so it got a bit sidelined. I've updated the PR to be in line with code changes that have happened in the meantime, and simplified the config format, as I felt it was a bit verbose.
- Update weapons knockback config to use up to 2 decimals (from
0.0f
to.2f
).
Any number of decimal places should already work, this is actually just the default value if parsing fails. This did bring to my attention that they should probably default to 1.0
though, so I went ahead and did that.
0.0f
to.2f
).