Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Z:R] Implement Hitgroup Knockback config, Zombie Class specific knockback config. #232

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

nuclearsilo583
Copy link
Contributor

@nuclearsilo583 nuclearsilo583 commented May 13, 2024

  • Update weapons knockback config to use up to 2 decimals (from 0.0f to .2f).
  • Add hitgroups feature like in old Zombie:Reloaded for more control in handling knockback. (Tested offline with bots and worked fine. Need test on full server).
  • Update "knockback" config in playerclass.jsonc (why adding this? Because zombie hitboxes are not the same due to difference in zombie model. Which could cause big model with big hitboxes become more disadvantage than other small model)

@Kxnrl
Copy link
Collaborator

Kxnrl commented May 14, 2024

hello? why still using KeyValues

@nuclearsilo583
Copy link
Contributor Author

sorry. It's my bad that I only know how to use KeyValues. I don't know how to use .jsonc. It would be great if someone has more experiences to help my bad code.

@Vauff
Copy link
Contributor

Vauff commented May 15, 2024

Should be fine, it's unlikely we'll ever migrate all our old cfgs away from KeyValues anyways, and this file is simple enough that JSON arrays should never be needed. That was really the only reason we justified the playerclass migration.

@nuclearsilo583 nuclearsilo583 force-pushed the dev branch 2 times, most recently from 06206b9 to 1d14e44 Compare May 19, 2024 14:02
@nuclearsilo583 nuclearsilo583 changed the title [Z:R] Implement Hitgroup Knockback for more handle aside Weapon Knockback. [Z:R] Implement Hitgroup Knockback config, Zombie Class specific knockback config. May 19, 2024
@Runo231
Copy link

Runo231 commented Aug 8, 2024

I test this in my server and work so nice +1 to merge

Copy link

@Runo231 Runo231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine lfm

Copy link
Contributor

@Vauff Vauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for the delay, none of the "dev servers" wanted to use this feature so it got a bit sidelined. I've updated the PR to be in line with code changes that have happened in the meantime, and simplified the config format, as I felt it was a bit verbose.

  • Update weapons knockback config to use up to 2 decimals (from 0.0f to .2f).

Any number of decimal places should already work, this is actually just the default value if parsing fails. This did bring to my attention that they should probably default to 1.0 though, so I went ahead and did that.

@Vauff Vauff merged commit ac5bb90 into Source2ZE:main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants