fix: fix database query builder alter dilimater #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anggerpradana
requested changes
Oct 25, 2024
There was a problem hiding this comment.
unfortunately the mysql 5.7 doesn't support using rename column. to solve the issue make exceptions in ci workflow for version my sql version 5.7. Work smoothly in mysql 8 and Mariadb version 10.5. so my solution is
- make 3 different workflow strategy
- skip for mysql ver 5.7
- add new alter api (change)
- add more workflow mysql 5.7, mysql 8, mariadb 10 - add group exclude for mysql 5,7
done except add new api (another pr) |
anggerpradana
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix database query builder alter dilimater.