Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCANMAVEN-238 Remove unauthenticated REST API calls to SonarQube during IT #247

Merged
merged 2 commits into from
Oct 28, 2024
Merged

SCANMAVEN-238 Remove unauthenticated REST API calls to SonarQube during IT #247

merged 2 commits into from
Oct 28, 2024

Conversation

alban-auzeill
Copy link
Member

@alban-auzeill alban-auzeill commented Oct 25, 2024 •
edited by jira bot
Loading

dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please have a look at whether we can removed the protected field from the abstract test class

its/src/test/java/com/sonar/maven/it/suite/AbstractMavenTest.java Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@alban-auzeill alban-auzeill merged commit 52c4e6d into master Oct 28, 2024
18 checks passed
@alban-auzeill alban-auzeill deleted the alban/SCANMAVEN-238 branch October 28, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alban-auzeill @dorian-burihabwa-sonarsource