Remove type-checking for Vue also on SL

SonarSource · Mar 18, 2024 · 58820cb · 58820cb
1 parent 1d02d85
commit 58820cb
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 29 deletions.
diff --git a/its/plugin/sonarlint-tests/src/test/java/SonarLintTest.java b/its/plugin/sonarlint-tests/src/test/java/SonarLintTest.java
@@ -175,7 +175,7 @@ void should_analyze_js_with_typed_rules_except_vue() throws IOException {
     fileName = "file.vue";
     content = Files.readString(TestUtils.projectDir("js-sonarlint-project").resolve(fileName));
     issues = analyze(fileName, content);
-    assertThat(issues).extracting(Issue::getRuleKey).contains("javascript:S3504");
+    assertThat(issues).extracting(Issue::getRuleKey).containsExactly("javascript:S3504");
   }
 
   @Test

diff --git a/packages/jsts/src/builders/build.ts b/packages/jsts/src/builders/build.ts
@@ -44,7 +44,7 @@ export function buildSourceCode(input: JsTsAnalysisInput, language: JsTsLanguage
       parser: vueFile ? parsers.typescript.parser : undefined,
     };
     const parser = vueFile ? parsers.vuejs : parsers.typescript;
-    if (getContext()?.sonarlint || !vueFile) {
+    if (!vueFile) {
       options.programs = input.programId && [getProgramById(input.programId)];
       options.project = input.tsConfigs;
     }

diff --git a/packages/jsts/tests/analysis/analyzer.test.ts b/packages/jsts/tests/analysis/analyzer.test.ts
@@ -123,33 +123,7 @@ describe('analyzeJSTS', () => {
     );
   });
 
-  it('should analyze Vue.js code with type checks in SL', async () => {
-    setContext({
-      workDir: '/tmp/dir',
-      shouldUseTypeScriptParserForJS: true,
-      sonarlint: true,
-      bundles: [],
-    });
-
-    const rules = [
-      { key: 'strings-comparison', configurations: [], fileTypeTarget: ['MAIN'] },
-    ] as RuleConfig[];
-    initializeLinter(rules);
-    const filePath = path.join(__dirname, 'fixtures', 'vue_ts', 'file.vue');
-    const tsConfigs = [path.join(__dirname, 'fixtures', 'vue_ts', 'tsconfig.json')];
-    const language = 'ts';
-
-    const {
-      issues: [issue1],
-    } = analyzeJSTS(await jsTsInput({ filePath, tsConfigs }), language) as JsTsAnalysisOutput;
-    expect(issue1).toEqual(
-      expect.objectContaining({
-        ruleId: 'strings-comparison',
-      }),
-    );
-  });
-
-  it('should not analyze Vue.js with type checks in SQ/SC', async () => {
+  it('should not analyze Vue.js with type checks in SQ/SC nor SL', async () => {
     const rules = [
       { key: 'strings-comparison', configurations: [], fileTypeTarget: ['MAIN'] },
     ] as RuleConfig[];
@@ -164,6 +138,18 @@ describe('analyzeJSTS', () => {
       language,
     ) as JsTsAnalysisOutput;
     expect(issues).toHaveLength(0);
+    setContext({
+      workDir: '/tmp/dir',
+      shouldUseTypeScriptParserForJS: true,
+      sonarlint: true,
+      bundles: [],
+    });
+
+    const { issues: issues_sl } = analyzeJSTS(
+      await jsTsInput({ filePath, tsConfigs }),
+      language,
+    ) as JsTsAnalysisOutput;
+    expect(issues_sl).toHaveLength(0);
   });
 
   it('should analyze main files', async () => {