-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show both layer time and tick info when tick is highlighted #2312
Conversation
Hold on... Just realized that the layer time is the time when current layer is completed, however pause happens at the beginning of current layer. This is confusing. |
Uh! That's a shame. 😅 Coming from Cura, this is what happend to confuse me as well!
What do you think? |
This will be the easier solution, however it might be inaccurate due to the existence of the before/after_layer_change gcode. For a layer with a pause, the gcodes are:
The layer time is calculated from (1) to (4), but the pause gcode is inserted at (3), so if (1), (2) take a lot of time, then the time of pause will be significantly different from previous layer's end time. |
But then, how accurate do we actually need? I think it's perfectly fine to use the previous layer's end time as a good estimation. |
That should suffice, because ideally you want to be there shortly before the actual pause so that you can immediately resume printing. Thank you a lot for taking this on! 😃👍 |
18cb1e5
to
b02eae2
Compare
Currently if pauses is added to the first layer then there is no previous layer finish time to use, hens it won't show the time. Other than that, this should be good. There is a way to get the start time of first layer however it's quite complicated, and I think this is a very edge use case which can be ignored for now. |
Thank you! |
Cool! |
This addresses the concern at #2305 (comment)