Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit checklist #262

Open
6 of 16 tasks
arthcp opened this issue Jun 19, 2023 · 1 comment
Open
6 of 16 tasks

Audit checklist #262

arthcp opened this issue Jun 19, 2023 · 1 comment

Comments

@arthcp
Copy link
Contributor

arthcp commented Jun 19, 2023

  • Use the latest major version of Solidity.
  • All happy path tests
  • All revert condition tests.
  • Run Slither/MythX
  • Run spellchecker
  • Fuzz tests, invariant testing
  • Recheck immutable setters in deploy scripts.
  • Test contracts hitting code size limit.
  • Check major functions for reentrancy attacks.
    • Function should set a unique variable at start that blocks reentry.
    • Function should handle storage variables safely.
    • Avoid if reentring a function doesnt have any impact to protocol.
  • Add natspec for all public/external functions.
  • Explain all id creations.
  • Explain usage of unchecked code blocks.
  • Prepare assumptions, external actors list.
  • Prepare audit goals list.
  • version lib usage?
  • execute try/catch
@arthcp
Copy link
Contributor Author

arthcp commented Jun 19, 2023

Audit Scope

capacitors/
  SingleCapacitor.sol
  BaseCapacitor.sol
decapacitors/
  SingleDecapacitor.sol
libraries/
  RescueFundsLib.sol
socket/
  Socket.sol
  SocketDst.sol
  SocketBase.sol
  SocketConfig.sol
  SocketSrc.sol
switchboard/
  default-switchboards/
    FastSwitchboard.sol
    OptimisticSwitchboard.sol
    SwitchboardBase.sol
  native/
    ArbitrumL1Switchboard.sol
    NativeSwitchboardBase.sol
    PolygonL1Switchboard.sol
    ArbitrumL2Switchboard.sol
    OptimismSwitchboard.sol
    PolygonL2Switchboard.sol
utils/
  AccessControl.sol
  AccessControlExtended.sol
  Hasher.sol
  Ownable.sol
  SignatureVerifier.sol
CapacitorFactory.sol
ExecutionManager.sol
OpenExecutionManager.sol
TransmitManager.sol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant