Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The example uses uint256 while Socket uses uint32 for chainSlug() #175

Open
gpersoon opened this issue May 3, 2023 · 1 comment
Open

Comments

@gpersoon
Copy link

gpersoon commented May 3, 2023

Describe the bug
The example uses uint256 while Socket uses uint32 for chainSlug().
The main ISocket.sol also misses the definition for chainSlug().

To Reproduce
Check out the following code:
socketDL-examples ISocket.sol#L79:

function chainSlug() external view returns (uint256 chainSlug);

socket-DL SocketBase.sol#L19:

uint32 public immutable chainSlug;

socket-DL ISocket.sol
no definition for chainSlug()

Expected behavior

  • the same type should be used everywhere (uint32)
  • chainSlug() should be present to socket-DL ISocket.sol

Additional context

@arthcp
Copy link
Contributor

arthcp commented Jun 28, 2023

Agree, need to upgrade examples to match the latest socket interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants