Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deactivate playwright on merge #1764

Merged
merged 1 commit into from
Nov 17, 2023
Merged

chore: deactivate playwright on merge #1764

merged 1 commit into from
Nov 17, 2023

Conversation

arnaudambro
Copy link
Contributor

@arnaudambro arnaudambro commented Nov 7, 2023 •
edited
Loading

pourquoi ?

  • parce que les tests ne sont pas bloquants quand on déploie en prod de toutes façons
  • parce que les tests nous intéressent surtout quand on fait une PR
  • parce que quand on pousse directement sur main, dans les faits on s'en fiche des tests puisque c'est un hotfix qu'on veut être déployé avec ou sans tests
  • parce que quand j'ai besoin d'envoyer un truc rapidement en prod comme il y a deux minutes, j'annule le workflow parce qu'il m'ennuie dans ce cas précis
  • parce qu'en plus ça fait du bien à la planète de supprimer un truc dont on ne se sert pas

qu'en dis-tu ?

@arnaudambro arnaudambro requested a review from a team as a code owner November 7, 2023 13:45
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rap2hpoutre
rap2hpoutre approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@rap2hpoutre rap2hpoutre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK !

@arnaudambro arnaudambro merged commit 214c9ac into main Nov 17, 2023
5 checks passed
@arnaudambro arnaudambro deleted the chore/deactivate-playwright-on-merge branch November 17, 2023 11:37
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.295.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rap2hpoutre rap2hpoutre rap2hpoutre approved these changes

Assignees

@arnaudambro arnaudambro

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnaudambro @SocialGroovyBot @rap2hpoutre