Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When given a multi-line secret in the schemachange-config YAML, it would not be redacted, because just before calling
SecretManager.global_redact
, the config vars section would be serialised as YAML, adding leading whitespaces to the multiline secretProposed solution
Recurse over the config vars section, and redact all strings in it, and only then serialise as YAML. When redacting multiline secrets, preserve newlines.
Minor edits added in
strip()
method. Added an explicit raise of a ValueError if a secret is not of typestr
Notes
For redacting in SQL queries nothing was changed, as indenting while rendering Jinja templates is under control of the user of schemachange.