Skip to content

Commit

Permalink
Leaving code comment to review later
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-tmathew committed Nov 22, 2024
1 parent 7e68ecf commit c05fa56
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions schemachange/config/DeployConfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ def get_session_kwargs(self) -> dict:
"query_tag": self.query_tag
}

#snowflake_password = get_snowflake_password()
#if snowflake_password is not None and snowflake_password:
# TODO: Discuss the need for check for snowflake password before passing the session
# kwargs to open a snowflake session
# snowflake_password = get_snowflake_password()
# if snowflake_password is not None and snowflake_password:
# session_kwargs["password"] = snowflake_password
return {k: v for k, v in session_kwargs.items() if v is not None}

0 comments on commit c05fa56

Please sign in to comment.