-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer Data - Add attribute type parser based on value #159
Comments
There are two ways I can think of how to tackle this:
|
Do we know what caused this functionality to break? |
Hey @micah-prime , this functionality broke because my new density tests were the first time we tried sending a value into the API logic that tests for greater or less than. Since value is a string it threw an error. Prior to that we had tested it with dates which had already been cast to the correct format. For now my proposed fix will be to add an additional type check in the API:
And similarly for |
Ah makes sense - nice find! |
An idea from a PR review comment
Since layer data can have multiple data types (i.e. INT for depth, but CHAR for hardness), we could think about adding a feature to the LayerData class that checks the value against known CHAR types and tries to typecast them.
Could also maybe use an ENUM to do this.
The text was updated successfully, but these errors were encountered: