input: Make TabletToolEvent depend on AbsolutePositionEvent, and apply output transform to tablet events in anvil
#1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TabletToolEvent` provides all the methods that are provide by `AbsolutePositionEvent`. Seemingly with the only difference that tablet events guarantee the untransformed coordinates are in mm, while it is otherwise unspecified with `AbsolutePositionEvent`. Re-using the `AbsolutePositionEvent` trait here makes it easier to share a bit of code for handling tablet and touch events.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1593 +/- ##
==========================================
- Coverage 19.61% 19.32% -0.30%
==========================================
Files 170 169 -1
Lines 27956 27608 -348
==========================================
- Hits 5484 5335 -149
+ Misses 22472 22273 -199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Drakulix
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
TabletToolEventprovides methods likeposition_transformed, but doesn't depend onAbsolutePositionEvent. This makes it slightly inconvenient to make generic code that handles both tablet and touch events.I think this is a reasonable way to change this.