Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for testing Neat URL 6.0.0 #269

Open
Smile4ever opened this issue Feb 6, 2022 · 22 comments
Open

Call for testing Neat URL 6.0.0 #269

Smile4ever opened this issue Feb 6, 2022 · 22 comments

Comments

@Smile4ever
Copy link
Owner

Smile4ever commented Feb 6, 2022

@gliptak @eslerm and everyone else
Neat URL 6.0.0 is almost out. Many bugs were fixed and some new features were introduced.

Bug reporters and enthousiasts, please test this version by loading it as an temporary addon.
In Firefox this is done through about:debugging -> This Firefox -> Load temporary addon

Although I tested it, it might contain unknown bugs.

The ZIP file you need (for version 6.0.0) can be found here:
https://github.com/Smile4ever/Neat-URL/tree/master/web-ext-artifacts

From the changelog

Special thanks to the contributors who made this version possible.

@Smile4ever Smile4ever pinned this issue Feb 6, 2022
@Smile4ever
Copy link
Owner Author

Smile4ever commented Feb 6, 2022

Note to self: enable/disable using the browseraction button doesn't seem to work currently.

Update: fixed (for browser.webrequest.onBeforeRequest), I have not tested this in combination with "change links in page" functionality

@Drugoy
Copy link

Drugoy commented Feb 6, 2022

"change links in page" feature doesn't seem to work for me. Navigate to yandex.com and hover over any news item in the news block (right under search form): the urls contain utm_* cancer.

Chromium: Version 97.0.4692.71 (Official Build) Built on Ubuntu , running on Ubuntu 18.04 (64-bit)

@t-matsuu
Copy link
Contributor

t-matsuu commented Mar 9, 2022

Distribute pre-release versions at the Mozilla add-ons site may help more users for testing on Firefox.

@eslerm
Copy link
Contributor

eslerm commented Mar 29, 2022

I'd love to see an updated pre-release version on Mozilla 🙏

Most of my friends who I'd recommend it to need it for the updated twitter and spotify rules.

@CharlesChiuGit
Copy link

CharlesChiuGit commented May 24, 2022

image

I have this error after I load the 6.0.0.

Uncaught ReferenceError: browser is not defined

I also tried to add [email protected] at Blocked parameters in the 5.0.0 which is mentioned in #237 , but it didn't worked too.

FYI. I'm on win11 with brave browser.

@Drugoy
Copy link

Drugoy commented May 24, 2022

The extension stopped working altogether on all latest versions anyways.

@8times4
Copy link

8times4 commented Jun 4, 2022

image

I have this error after I load the 6.0.0.

Uncaught ReferenceError: browser is not defined

I also tried to add [email protected] at Blocked parameters in the 5.0.0 which is mentioned in #237 , but it didn't worked too.

FYI. I'm on win11 with brave browser.

Try t@*.twitter.com instead, that works for me on Firefox.
@CharlesChiuGit

@eslerm
Copy link
Contributor

eslerm commented Jun 6, 2022

@CharlesChiuGit do you get this issue in Chrome/Chromium as well?

@CharlesChiuGit
Copy link

@eslerm Sorry, I don't have Chrome/Chromium installed on my machines, I couldn't test it out.

@CharlesChiuGit
Copy link

CharlesChiuGit commented Jun 6, 2022

Try t@*.twitter.com instead, that works for me on Firefox.

@8times4 Sure! I'll try it when the bug is fixed!

@mmortal03
Copy link

I can't get it to remove parameters when the URL is twitter.com, but it will remove parameters when the URL is www.twitter.com

This is broken both in 5.0.0 and in 6.0.0 (where it is part of the defaults, but still doesn't work)

Example: https://twitter.com/ShamsCharania/status/1543675702947594241?cxt=HHwWgoC-qfC3nuwqAAAA

Tried both of these:

cxt@*.twitter.com, [email protected]

@eslerm
Copy link
Contributor

eslerm commented Aug 9, 2022

@Smile4ever what is left to do to for release 6.0.0?

Can that release be pushed to the Firefox and Chrome extension stores after?

What can I do to help?

@Smile4ever
Copy link
Owner Author

@eslerm

Remaining:

I will start the release process in September after these issues have been fixed (due to personal time constraints), either by pull requests or by me. This means that by end of September there should be a new version in the Chrome and Firefox stores (if there are no issues with Manifest V3).

@eslerm
Copy link
Contributor

eslerm commented Aug 14, 2022

Do you mean CharleChiuGit instead of 8times4?

CharleChiuGit's issue seems related to the Brave browser.

browser is used a lot in Neat URL and it is mentioned as being out of scope in their error message. https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API

@eslerm
Copy link
Contributor

eslerm commented Aug 14, 2022

#287 fixes #285

I believe it resolve what @mmortal03's needs too. With it I can set cxt@*.twitter.com.

@mmortal03
Copy link

mmortal03 commented Aug 14, 2022

#287 fixes #285

I believe it resolve what @mmortal03's needs too. With it I can set cxt@*.twitter.com.

Hi @eslerm,

Unfortunately, I just tried #287, and it doesn't fix the issue with twitter.com pages not being handled vs www.twitter.com pages being handled.

Testing with #287, cxt@*.twitter.com remains the default (which would be fine) but it doesn't work on twitter.com. I added [email protected], but that also didn't work. I even tried adding cxt@*.twitter.com, too, but, to be sure, it didn't help.

@eslerm
Copy link
Contributor

eslerm commented Aug 14, 2022

Hi @mmortal03,

Could you open an issue to describe this? If you can add the examples you have posted here and the browser your are using I'd appreciate it. I'll take a look.

fwiw, the example URL in your first comment is working for me on Firefox 103.0.1 and I have no custom parameters set.

@mmortal03
Copy link

@eslerm , yep, I can open an issue. But just to give you a heads up, I did some further testing, with an interesting result. I believe Firefox works correctly, whereas Chrome does not. But it's more complicated than that. I tested in an incognito Chrome window, with no other extension loaded, and the initial time it actually worked correctly -- however, then I typed in www.google.com and hit enter, then pasted in the test URL and hit enter, and it didn't remove the cxt garbage. Actually, it might take a couple iterations of going to Google, and then going to the test URL before you notice it not working. You don't have to copy and paste the test URL, either. It can be a bookmark. You can also just open a new tab, paste it in, open a new tab, paste it in, etc. Eventually, it won't catch it.

@mmortal03
Copy link

#288

@reagle
Copy link

reagle commented Oct 14, 2022

What happened to the 6.0.0 release?

@t-matsuu
Copy link
Contributor

What happened to the 6.0.0 release?

All issues labeled "neat-url-6.0.0" should be fixed before release 6.0.0.

@Almighty188
Copy link

With the Neat URL Browser Extension for Chrome versions 5.00 release and 6.0.0 pre-release, the URL www.homedepot.com/mycard does not work

Without the extension enabled, it will redirect to:
https://citiretailservices.citibankonline.com/RSnextgen/svc/launch/index.action?siteId=PLCN_HOMEDEPOT#signon?cm_sp=vanity-_-mycard-_-MAY17
and the page will load up correctly.

With the extension enabled, both versions 5.00 release and 6.0.0 pre-release, it goes to the URL:
https://citiretailservices.citibankonline.com/RSnextgen/svc/launch/index.action?siteId=null&JFP_TOKEN=MB3OZOW1#signon
and then show the following screen:
image

This is also reported as #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants