Add data- attributes for opening-hours dropdown widget on store details #126
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In checkout, when choosing a pick up store and checking out opening hours in store details, dropdown widget is not properly working if we click on .showopeninghours element (shopStatus)
I'd like to know if you reproduce, because i extended this part and made a few modifications.
In my environment,
data-role="openingHoursDropDown"anddata-block="opening-hours-dropdown"are missing in final html because they are in open-hours-view.html template, which is only displayed on smile_store_locator-store-search page.These attributes are used in initDropdown() and i only propose to put them in opening-hours.html template to restore dropdown functionnality.
Regards