Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video responsiveness on devices smaller than tablet #5

Open
Agent9G opened this issue Sep 4, 2019 · 4 comments
Open

Video responsiveness on devices smaller than tablet #5

Agent9G opened this issue Sep 4, 2019 · 4 comments

Comments

@Agent9G
Copy link

Agent9G commented Sep 4, 2019

Hi again guys,

I see in your VideoBg.module.css that you have 'display:none' set with a max-width of 768px, so basically tablets.

What's up with this?

I would like the background to show in mobile as well and likely have the ability to do a background-position: center center, or the like.

Also, your code in VideoBg.js relating to the wrapperClass and videoClass props is not quite clear, at least to me.

Do you think you could add those attributes to your demo, so one can quickly see how that works?

@JamesBotterill
Copy link

@samAbeywickrama I'm also running into this.

@natelandon
Copy link

I had the same issue. I went into NodeModules folder and edited the bundle.esm.js, bundle.umd.js and bundle.cjs.js. It was set to display: none and I changed it to display: block; to get it to work properly on smaller screens.

@Agent9G
Copy link
Author

Agent9G commented Mar 15, 2020

I mentioned the issue in my first comment; but further clarification is good @natelandon

This is what I ended up making; except I did so without this: another-one-98483.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants