CHAD-14284: Test zigbee health monitoring opt out with zigbee-motion and zigbee-contact drivers #1816
Conversation
…and zigbee-contact drivers
kiera-robinson-st
requested review from
cjswedes,
NoahCornell,
tandres and
varzac
Test Results 64 files 402 suites 0s ⏱️ Results for commit 6ce6cc3. ♻️ This comment has been updated with latest results. |
|
zigbee-contact_coverage.xml
zigbee-motion-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6ce6cc3 |
|
Looks like there is a test for |
| @@ -31,7 +31,7 @@ local mock_device = test.mock_device.build_test_zigbee_device( | |||
| zigbee_test_utils.prepare_zigbee_env_info() | |||
| local function test_init() | |||
| test.mock_device.add_test_device(mock_device) | |||
| zigbee_test_utils.init_noop_health_check_timer() | |||
| --zigbee_test_utils.init_noop_health_check_timer() removal due to change to stop health checks going forward | |||
There was a problem hiding this comment.
Since the health check disable is happening in the base driver, we will need to remove this test config from all of the tests in the test/ folder, not just this test. The same for the motion driver.
…and zigbee-contact drivers; commented out `--zigbee_test_utils.init_noop_health_check_timer()` in test config from all tests for Zigbee motion sensor and Zigbee contact sensor
…and zigbee-contact drivers; commented out any tests that involved health checking
|
FYI, I think we should hold off merging this for a little bit, so that it ends up going to production after the new year. I will have more time to monitor the heavily used drivers then. cc: @varzac |
|
|
Check all that apply
Type of Change
Checklist
Description of Change
Changed health check action for 2 drivers and their associated tests: zigbee-motion and zigbee-contact
Summary of Completed Tests
This is not needed to keep device online, and so its being removed to gain the small memory/latency savings of having it disabled. Overnight tests were done for both zigbee-motion and zigbee-contact drivers.