Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile for NEO SmartPlug/Button device #1806

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Dec 9, 2024

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

CHAD-14507

Add a new profile in the matter-switch driver for NEO plug + button device (see WWSTCERT-4757). Note that this profile was originally going to be added by PR 1799, but that PR was split into two, so that the profile could be expediated into production to support the WWST certification.

Summary of Completed Tests

Copy link

github-actions bot commented Dec 9, 2024

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Dec 9, 2024

Channel deleted.

Copy link
Contributor

@ctowns ctowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only profile that is needed, right? I noticed there were a few more in the other PR, but I assume those were just added for completeness, not for other WWST devices

Copy link

github-actions bot commented Dec 9, 2024

Test Results

   64 files    402 suites   0s ⏱️
2 000 tests 2 000 ✅ 0 💤 0 ❌
3 455 runs  3 455 ✅ 0 💤 0 ❌

Results for commit e496172.

Copy link

github-actions bot commented Dec 9, 2024

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua 38%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua 96%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against e496172

@nickolas-deboom
Copy link
Contributor Author

This is the only profile that is needed, right? I noticed there were a few more in the other PR, but I assume those were just added for completeness, not for other WWST devices

Yes, that's correct. The other profiles will be added by PR 1807.

@nickolas-deboom nickolas-deboom merged commit f8f29b9 into main Dec 9, 2024
12 checks passed
@nickolas-deboom nickolas-deboom deleted the matter-switch-add-plug-button-profile branch December 9, 2024 18:58
ctowns pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants