Use rpc to check if larger temp range can be used #1757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
CHAD-14205
For RPC version >= 6, the edge drivers can always assume that temperature values received from the setTemperatureSetpoint command are in Celsius. We can therefore allow a larger range for setpoint values in the driver, because we no longer need to be concerned about the Celsius and Fahrenheit scales overlapping. This PR introduces new limits depending on the RPC version, which are larger than the current ranges, but still limit the setpoint range values as a type of "sanity check" on the values received from the device (sometimes the values from the device are not set, or are not reasonable). Please offer any feedback if you have any opinions on different values that should be used for each device type.
Summary of Completed Tests
See new unit tests.