Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuya gas sensor support #1714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pInksenberg
Copy link
Contributor

@pInksenberg pInksenberg commented Oct 23, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Add tuya Gas sensor support.
Tuya Gas alarm using smokeCO cluster exposed as matter bridged devices, they want to WWST and make this device as Gas sensor work with smartthing. This PR subscribe smokeCO COstate as Gas decetor state, try to support Tuya Gas alarm on Smartthings.

Summary of Completed Tests

Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

Copy link

github-actions bot commented Oct 23, 2024

Test Results

   64 files    401 suites   0s ⏱️
1 989 tests 1 989 ✅ 0 💤 0 ❌
3 430 runs  3 430 ✅ 0 💤 0 ❌

Results for commit b2e7361.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 23, 2024

File Coverage
All files 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/tuya-smoke-co-alarm/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 45%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 92%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against b2e7361

@pInksenberg pInksenberg force-pushed the Tuya-gas-sensor-support branch 2 times, most recently from 07e42e1 to ef43e0a Compare October 28, 2024 09:01
@pInksenberg pInksenberg force-pushed the Tuya-gas-sensor-support branch from ef43e0a to b2e7361 Compare October 28, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant