New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DL-Learner to use builder pattern or similar #41

Open

SimonBin opened this issue Jun 17, 2016 · 0 comments

Assignees

Labels

DL-Learner enhancement

Milestone

Member

SimonBin commented Jun 17, 2016 •

edited

Loading

Alternatively throw exceptions in all public methods, whether they are pre-init or post-init methods. Or research other options to stop incorrect DL-Learner usage (by which I mean: calling set Methods after .init or calling methods before .init has been done) Sample exception I added for some specific case in RhoDRDown: https://github.com/AKSW/DL-Learner/blob/94da38d7c1e1adc8ee7613c1938a3a550a0d4a23/components-core/src/main/java/org/dllearner/refinementoperators/RhoDRDown.java#L472

SimonBin added the enhancement label

patrickwestphal added the DL-Learner label

patrickwestphal assigned SimonBin

patrickwestphal added this to the 1.5 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment