Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WiFiscan not working when not connected #293

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

unlogisch04
Copy link
Contributor

also changed tab to 4 space, and a 1 line if to a 3 line if

@ImUrX
Copy link
Member

ImUrX commented Sep 25, 2023

you should have made the tab change in a different commit, diff is not readable qwq
And the editorconfig specifies tab instead of space

@unlogisch04
Copy link
Contributor Author

Ok i had to search a littlebit what should be.
Seems like to be tab the correct one for future:
https://discord.com/channels/817184208525983775/959133879682342962/1089772491486011465
#235

Fix WiFiscan not working when not connected
@unlogisch04
Copy link
Contributor Author

Ok, i did not have "EditorConfig for VS Code" installed so the rules where not applied on my code

Copy link
Member

@TheDevMinerTV TheDevMinerTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TheDevMinerTV TheDevMinerTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheDevMinerTV
Copy link
Member

ignore that I reviewed twice 😱

@Eirenliel Eirenliel merged commit 10125c7 into SlimeVR:main Oct 13, 2023
1 check passed
@unlogisch04 unlogisch04 deleted the fix_wifiscan branch October 15, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants