Reduce Memory pressure of UpgradePath #5060
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryLoenwind
approved these changes
Mar 4, 2019
tterrag1098
reviewed
Mar 15, 2019
| @@ -188,6 +187,12 @@ public static void addAdvancedTooltipEntries(@Nonnull ItemStack itemstack, Entit | |||
| return result.isEmpty() ? "" : NullHelper.first(result.substring(1), ""); | |||
| } | |||
|
|
|||
| public static @Nonnull NNList<IDarkSteelUpgrade> getUpgrades(@Nonnull ItemStack stack) { | |||
| NNList<IDarkSteelUpgrade> list = UpgradeRegistry.getUpgrades(); | |||
| list.removeIf(upgrade -> !upgrade.hasUpgrade(stack)); | |||
There was a problem hiding this comment.
I worry that this O(n) code is going to slow down the JEI handler significantly. Have you profiled the difference?
HenryLoenwind
added a commit
that referenced
this pull request
May 8, 2019
This is a safer but not as efficient version of #5060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I did some memory analysis on large modpacks, trying to reduce the memory pressure.
I noticed that the HashMap in your DarkSteelUpgradeRecipeCategory is taking up around 150MB of heap space. If you look at the objects inside the map that take, you find that 45MB of the 150MB are just char arrays. This is because the String id can grow quite huge.
My solution is to simply remove the id, and cache the hashcode instead.
The equals check should not be much slower, as it fails fast for different input items
The result is that DarkSteelRecipeManager uses around 45MB less memory.
Some screenshots from eclipse MAT:
Without my changes:
With the changes in this PR: