Fix Fluid Conduit failure to extract #3690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Fluid Conduit adjacent to multiple fluid containers, set to "Extract" on all of them, will stop extracting as soon as any of them become empty. A quick look at the source code suggests this line is the problem. So, I'm giving you a completely untested change to a no-longer-maintained branch of your project just in case somebody finds it useful. Cheers!
|
Is this only for Ender IO 2.2 or would this also apply to 2.3? (branch master) |
|
Looks like it can be applied to master: https://github.com/SleepyTrousers/EnderIO/blob/master/src/main/java/crazypants/enderio/conduit/liquid/LiquidConduit.java#L143 |
|
#3691 is this same change, based on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Fluid Conduit adjacent to multiple fluid containers, set to "Extract" on all of them, will stop extracting as soon as any of them become empty. A quick look at the source code suggests this line is the problem.
So, I'm giving you a completely untested change to a no-longer-maintained branch of your project just in case somebody finds it useful. Cheers!